Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 849623003: dart2js: start using the model in the old emitter. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: start using the model in the old emitter. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42902

Patch Set 1 #

Patch Set 2 : More uses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -76 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 chunks +16 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 12 chunks +58 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 5 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
The transition is not yet complete, and in theory we are now doing more work. ...
5 years, 11 months ago (2015-01-14 16:55:54 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-15 08:41:17 UTC) #3
floitsch
5 years, 11 months ago (2015-01-15 11:55:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698