Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 849023002: format code, removed unused variables and deprecated usage (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/args.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

format code, removed unused variables and deprecated usage R=sigmund@google.com Committed: https://github.com/dart-lang/args/commit/219a1485d9daadf38b493071da3bae1e50e1aefb

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -287 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -1 line 0 comments Download
M example/test_runner.dart View 2 chunks +93 lines, -62 lines 0 comments Download
M lib/command_runner.dart View 8 chunks +15 lines, -17 lines 0 comments Download
M lib/src/arg_parser.dart View 3 chunks +15 lines, -14 lines 0 comments Download
M lib/src/arg_results.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/option.dart View 3 chunks +9 lines, -8 lines 0 comments Download
M lib/src/parser.dart View 6 chunks +13 lines, -14 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/args_test.dart View 8 chunks +28 lines, -24 lines 0 comments Download
M test/command_parse_test.dart View 11 chunks +31 lines, -33 lines 0 comments Download
M test/command_runner_test.dart View 6 chunks +17 lines, -23 lines 0 comments Download
M test/command_test.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M test/parse_test.dart View 5 chunks +27 lines, -27 lines 0 comments Download
M test/trailing_options_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M test/usage_test.dart View 16 chunks +33 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
Follow on to https://codereview.chromium.org/849983002/
5 years, 11 months ago (2015-01-14 01:33:15 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/849023002/diff/1/test/args_test.dart File test/args_test.dart (right): https://codereview.chromium.org/849023002/diff/1/test/args_test.dart#newcode306 test/args_test.dart:306: 'contains-dash', oh, weird, can you file a bug ...
5 years, 11 months ago (2015-01-14 01:37:47 UTC) #3
kevmoo
Committed patchset #2 (id:20001) manually as 219a1485d9daadf38b493071da3bae1e50e1aefb (presubmit successful).
5 years, 11 months ago (2015-01-14 01:39:59 UTC) #4
kevmoo
5 years, 11 months ago (2015-01-14 01:47:47 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/849023002/diff/1/test/args_test.dart
File test/args_test.dart (right):

https://codereview.chromium.org/849023002/diff/1/test/args_test.dart#newcode306
test/args_test.dart:306: 'contains-dash',
On 2015/01/14 01:37:47, Siggi Cherem (dart-lang) wrote:
> oh, weird, can you file a bug in dart_style about this one?

https://github.com/dart-lang/dart_style/issues/138

Powered by Google App Engine
This is Rietveld 408576698