Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 848943002: fix function type alias conversion to protocol element (Closed)

Created:
5 years, 11 months ago by danrubel
Modified:
5 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

fix function type alias conversion to protocol element BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42850

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
M pkg/analysis_server/lib/src/protocol_server.dart View 2 chunks +25 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 11 months ago (2015-01-13 19:26:42 UTC) #2
Paul Berry
lgtm
5 years, 11 months ago (2015-01-13 19:44:07 UTC) #3
danrubel
5 years, 11 months ago (2015-01-14 01:58:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698