Pluggable lint verifiers first step and basic lint task tests.

Pluggable lint verifiers first step and basic lint task tests.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42778

[pquitslund, 2015-01-09 23:33:46]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-01-10 00:26:53]

LGTM

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/engine_test.dart (right):

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/engine_test.dart:4015: void test_getException() {
Ah. The tests didn't get renamed when the methods were converted to getters. The
original pattern, which you don't have to follow, was for the second part of the
name to be the method being tested.

[scheglov, 2015-01-10 00:58:12]

LGTM

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:4487: [Iterable<LintVerifier>
verifiers])
Why is it optional?
Do we expect that we will ever want to create LintGenerator without providing a
list?

[pquitslund, 2015-01-12 16:44:44]

Thanks!

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:4487: [Iterable<LintVerifier>
verifiers])
On 2015/01/10 00:58:11, scheglov wrote:
> Why is it optional?
> Do we expect that we will ever want to create LintGenerator without providing
a
> list?

Actually, the common use case is to NOT provide the list and use the global
container that gets contributed to via plugins. Providing verifiers sidesteps
contributions for testing purposes.

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/engine_test.dart (right):

https://codereview.chromium.org/848463003/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/engine_test.dart:4015: void test_getException() {
On 2015/01/10 00:26:53, Brian Wilkerson wrote:
> Ah. The tests didn't get renamed when the methods were converted to getters.
The
> original pattern, which you don't have to follow, was for the second part of
the
> name to be the method being tested.

Ah, got it.  Fixed!

[pquitslund, 2015-01-12 16:45:10]

Committed patchset #1 (id:1) manually as r42778 (presubmit successful).