Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 848393005: Command line parsing utilities. Not yet used in observatory. (Closed)

Created:
5 years, 11 months ago by turnidge
Modified:
5 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Command line parsing utilities. Not yet used in observatory. BUG= Committed: https://code.google.com/p/dart/source/detail?r=42968

Patch Set 1 #

Total comments: 6

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -6 lines) Patch
A + runtime/observatory/lib/cli.dart View 1 1 chunk +4 lines, -6 lines 0 comments Download
A runtime/observatory/lib/src/cli/command.dart View 1 1 chunk +174 lines, -0 lines 0 comments Download
A runtime/observatory/test/command_test.dart View 1 1 chunk +193 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
Reheated the old cl. Renamed the "debugger" library to "cli" to be more accurate.
5 years, 11 months ago (2015-01-15 21:54:17 UTC) #2
Cutch
LGTMwC https://codereview.chromium.org/848393005/diff/1/runtime/observatory/lib/cli.dart File runtime/observatory/lib/cli.dart (right): https://codereview.chromium.org/848393005/diff/1/runtime/observatory/lib/cli.dart#newcode1 runtime/observatory/lib/cli.dart:1: // Copyright (c) 2014, the Dart project authors. ...
5 years, 11 months ago (2015-01-15 22:00:08 UTC) #3
turnidge
https://codereview.chromium.org/848393005/diff/1/runtime/observatory/lib/cli.dart File runtime/observatory/lib/cli.dart (right): https://codereview.chromium.org/848393005/diff/1/runtime/observatory/lib/cli.dart#newcode1 runtime/observatory/lib/cli.dart:1: // Copyright (c) 2014, the Dart project authors. Please ...
5 years, 11 months ago (2015-01-16 18:27:42 UTC) #4
turnidge
5 years, 11 months ago (2015-01-16 18:45:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42968 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698