Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 848063003: dart2js: move NativeEmitter into js_emitter directory. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther, zarah
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: move NativeEmitter into js_emitter directory. R=johnniwinther@google.com, zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42957

Patch Set 1 #

Patch Set 2 : Remove spurious new line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -486 lines) Patch
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/compiler/lib/src/js_backend/native_emitter.dart View 1 chunk +0 lines, -479 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + pkg/compiler/lib/src/js_emitter/native_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
5 years, 11 months ago (2015-01-15 21:10:52 UTC) #2
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-16 08:25:58 UTC) #4
zarah
LGTM
5 years, 11 months ago (2015-01-16 08:53:05 UTC) #5
floitsch
5 years, 11 months ago (2015-01-16 14:17:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698