Add indication of instrumentation active/inactive to analysis server status.

Add indication of instrumentation active/inactive to analysis server status.

The instrumentation status shows up when querying the "/status" page, when analysis server is started with the "--port" option.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42879

[Paul Berry, 2015-01-13 22:26:49]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-01-13 22:33:30]

LGTM

https://codereview.chromium.org/847963003/diff/1/pkg/analyzer/lib/instrumenta...
File pkg/analyzer/lib/instrumentation/instrumentation.dart (right):

https://codereview.chromium.org/847963003/diff/1/pkg/analyzer/lib/instrumenta...
pkg/analyzer/lib/instrumentation/instrumentation.dart:79: * Return true if this
[InstrumentationService] was initialized with a
nit: "true" --> "`true`", "null" --> "`null`"

https://codereview.chromium.org/847963003/diff/1/pkg/analyzer/lib/instrumenta...
pkg/analyzer/lib/instrumentation/instrumentation.dart:113: if
(_instrumentationServer != null) {
We should replace existing tests of this form with "isActive".

[Paul Berry, 2015-01-14 18:23:04]

https://codereview.chromium.org/847963003/diff/1/pkg/analyzer/lib/instrumenta...
File pkg/analyzer/lib/instrumentation/instrumentation.dart (right):

https://codereview.chromium.org/847963003/diff/1/pkg/analyzer/lib/instrumenta...
pkg/analyzer/lib/instrumentation/instrumentation.dart:79: * Return true if this
[InstrumentationService] was initialized with a
On 2015/01/13 22:33:29, Brian Wilkerson wrote:
> nit: "true" --> "`true`", "null" --> "`null`"

Done.

https://codereview.chromium.org/847963003/diff/1/pkg/analyzer/lib/instrumenta...
pkg/analyzer/lib/instrumentation/instrumentation.dart:113: if
(_instrumentationServer != null) {
On 2015/01/13 22:33:29, Brian Wilkerson wrote:
> We should replace existing tests of this form with "isActive".

Agreed.  I'll do a follow-up CL.

[Paul Berry, 2015-01-14 18:23:27]

Committed patchset #1 (id:1) manually as 42879 (presubmit successful).