Outputing comma-separated report with percentages

Outputing comma-separated report with percentages

Merged:

http://crrev.com/832583003
http://crrev.com/843553004

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42831

[kevmoo, 2015-01-12 22:03:39]

kevmoo@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2015-01-13 08:03:01]

lgtm, mostly comments to my own code :-)

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
File tools/testing/dart/status_reporter.dart (right):

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:94: print('Building - please be patient
we build a lot of crap');
I know I wrote this, but maybe change the wording

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:98: var result =
Process.runSync('python',  ['tools/build.py', '-mrelease,debug',
add comment stating:
// We build runtime to be able to list cc tests

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:102: print('ERROR');
remove this line

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:104: print(result.stderr);
trow after this, we don't want to pretend we can run the tests if we can't build

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:106: print('done building');
s/done/Done

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:124: throw 'Foobar';
Trow a better string than Foobar here:
This is just a sanity check, but maybe:
throw 'Counts don't add up to total, please validate manually';

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:144: throw "Error running";
'Error running: ${args.join(" ")}';

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:150: var report =
result.stdout.substring(totalIndex+5);
space around +

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/test_opti...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:225: 'jsonOnly',
we don't store these using camel case, and to be specific, I would call this:
--report-in-json

[kevmoo, 2015-01-13 19:27:35]

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
File tools/testing/dart/status_reporter.dart (right):

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:94: print('Building - please be patient
we build a lot of crap');
On 2015/01/13 08:03:00, ricow1 wrote:
> I know I wrote this, but maybe change the wording

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:98: var result =
Process.runSync('python',  ['tools/build.py', '-mrelease,debug',
On 2015/01/13 08:03:01, ricow1 wrote:
> add comment stating:
> // We build runtime to be able to list cc tests

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:102: print('ERROR');
On 2015/01/13 08:03:01, ricow1 wrote:
> remove this line

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:104: print(result.stderr);
On 2015/01/13 08:03:01, ricow1 wrote:
> trow after this, we don't want to pretend we can run the tests if we can't
build

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:106: print('done building');
On 2015/01/13 08:03:00, ricow1 wrote:
> s/done/Done

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:124: throw 'Foobar';
On 2015/01/13 08:03:01, ricow1 wrote:
> Trow a better string than Foobar here:
> This is just a sanity check, but maybe:
> throw 'Counts don't add up to total, please validate manually';

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:144: throw "Error running";
On 2015/01/13 08:03:00, ricow1 wrote:
> 'Error running: ${args.join(" ")}';

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/status_re...
tools/testing/dart/status_reporter.dart:150: var report =
result.stdout.substring(totalIndex+5);
On 2015/01/13 08:03:01, ricow1 wrote:
> space around +

Done.

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/test_opti...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/847873004/diff/1/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:225: 'jsonOnly',
On 2015/01/13 08:03:01, ricow1 wrote:
> we don't store these using camel case, and to be specific, I would call this:
> --report-in-json

Done.

[kevmoo, 2015-01-13 19:27:56]

Committed patchset #2 (id:20001) manually as 42831 (presubmit successful).