Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 847573003: Push updates to browser. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Johnni Winther, lukechurch
Target Ref:
refs/heads/push_updates
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with r43061. #

Patch Set 3 : Update package:browser version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -13 lines) Patch
M dart/pkg/browser/lib/dart.js View 1 chunk +16 lines, -0 lines 0 comments Download
M dart/pkg/browser/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dart/pkg/dart2js_incremental/lib/compiler.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/dart2js_incremental.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/pkg/dart2js_incremental/lib/server.dart View 8 chunks +31 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
Vijay, I've made changes to pkg/browser/dart.js. The changes should be backwards compatible, but do I ...
5 years, 11 months ago (2015-01-21 13:27:46 UTC) #2
vsm
On 2015/01/21 13:27:46, ahe wrote: > Vijay, I've made changes to pkg/browser/dart.js. The changes should ...
5 years, 11 months ago (2015-01-21 21:22:12 UTC) #3
kasperl
LGTM.
5 years, 11 months ago (2015-01-22 07:26:53 UTC) #4
ahe
Thank you, Vijay and Kasper! I've updated the version to 0.10.1, and will submit now. ...
5 years, 11 months ago (2015-01-22 10:02:06 UTC) #5
ahe
5 years, 11 months ago (2015-01-22 10:02:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 43063 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698