Issue 847173002: Match some constructor-based annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 847173002: Match some constructor-based annotations. (Closed)

Created:
5 years, 11 months ago by scheglov

Modified:
5 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Match some constructor-based annotations. It doesn't validate argments (we don't have them in annotation, and even if we had, it is still not cheap to compare nodes with values, but we could remember source strings, as we do for default parameter values), but it should not cause invalid resolution, because we resolve incrementally only changes in methods bodies. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42822

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -8 lines)			Patch
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		1 chunk	+13 lines, -6 lines	0 comments	Download
	M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View		4 chunks	+46 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 11 months ago (2015-01-13 17:13:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42822 (presubmit successful).

Expand Messages | Collapse Messages