Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 846723002: Make domains plugable (Closed)

Created:
5 years, 11 months ago by Brian Wilkerson
Modified:
5 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -40 lines) Patch
M pkg/analysis_server/lib/driver.dart View 4 chunks +28 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_impl.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 4 chunks +53 lines, -5 lines 2 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 4 chunks +4 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 7 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 11 months ago (2015-01-09 21:30:56 UTC) #2
scheglov
LGTM https://codereview.chromium.org/846723002/diff/1/pkg/analysis_server/lib/src/plugin/server_plugin.dart File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right): https://codereview.chromium.org/846723002/diff/1/pkg/analysis_server/lib/src/plugin/server_plugin.dart#newcode102 pkg/analysis_server/lib/src/plugin/server_plugin.dart:102: var id = domainExtensionPoint.uniqueIdentifier; String?
5 years, 11 months ago (2015-01-09 21:37:46 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/846723002/diff/1/pkg/analysis_server/lib/src/plugin/server_plugin.dart File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right): https://codereview.chromium.org/846723002/diff/1/pkg/analysis_server/lib/src/plugin/server_plugin.dart#newcode102 pkg/analysis_server/lib/src/plugin/server_plugin.dart:102: var id = domainExtensionPoint.uniqueIdentifier; Done
5 years, 11 months ago (2015-01-09 22:14:53 UTC) #4
Brian Wilkerson
5 years, 11 months ago (2015-01-09 22:15:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 42756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698