Dart2dart: Support for-loop variables captured in loop body.

Dart2dart: Support for-loop variables captured in loop body.

Capture in initializer, condition, and update is still not supported.

IMO: we should postpone efforts toward full capture support in dart2dart
until benchmarks indicate that dart2dart actually benefits from the
translation through CPS (which is still an open question, yes?).

Such benchmarking should not be blocked by lack of completeness,
because real code probably never captures loop variables in the loop
header.

R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42959

[asgerf, 2015-01-14 08:55:56]

asgerf@google.com changed reviewers:
+ karlklose@google.com, kmillikin@google.com, sigurdm@google.com

[asgerf, 2015-01-14 08:55:57]

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (left):

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:1446: }
Moved to subclass because 'this' capture is JS-specific.

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:221: void
_enterClosureEnvironment(ClosureEnvironment env);
I reverted to the "enterXXX" naming scheme because names like
"buildForLoopInitializerScopeSetup" are not that helpful.

Instead I named these functions based on how they are used rather than what they
do.

[sigurdm, 2015-01-14 12:02:48]

lgtm

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:225: /// This does not called
for for-loops, which instead use the methods
This 'is' not

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:866: /// [loopVariables] is the
list of variable declared in the for-loop
variable -> variables

[asgerf, 2015-01-14 12:08:21]

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:225: /// This does not called
for for-loops, which instead use the methods
On 2015/01/14 12:02:48, sigurdm wrote:
> This 'is' not

Thanks.

https://codereview.chromium.org/846353002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:866: /// [loopVariables] is the
list of variable declared in the for-loop
On 2015/01/14 12:02:48, sigurdm wrote:
> variable -> variables

Thanks again.

[asgerf, 2015-01-16 14:56:37]

Committed patchset #5 (id:80001) manually as 42959 (presubmit successful).