Do not ignore core libraries from CHA analysis

Do not ignore core libraries from CHA analysis.

I ran into issues with the collections library where classes and types were being finalized very late, affecting cha analysis.

R=fschneider@google.com, iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42874

[Cutch, 2015-01-14 00:08:23]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com, iposva@google.com

[Ivan Posva, 2015-01-14 04:35:10]

Change LGTM, but description is a bit misleading.

The issue is that there is no guarantee that no subclasses will be introduced in
these libraries. With lazy, on-demand class finalization it is almost guaranteed
to happen.

-Ivan

[Florian Schneider, 2015-01-14 12:00:23]

LGTM if you add a regression test.

[Cutch, 2015-01-14 17:02:17]

On 2015/01/14 12:00:23, Florian Schneider wrote:
> LGTM if you add a regression test.

I'm having trouble creating a small reproduction. I have a larger CL which does
reproduce the issue easily that I will be landing soon. The bug manifests
itself:

Class '_HashMapEntry' has no instance getter '_previousEntry'.

NoSuchMethodError: method not found: '_previousEntry'
Receiver: Instance of '_HashMapEntry'
Arguments: []
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
#1      _HashMap&&_LinkedHashMapMixin._removeEntry
(dart:collection-patch/collection_patch.dart:1012)
#2      _HashMap.remove (dart:collection-patch/collection_patch.dart:166)
#3      _IOService._initialize.<anonymous closure>
(dart:io-patch/io_service_patch.dart:43)
#4      _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:142)


Below are two traces, the first trace is with this CL applied and the second is
without:

With fix:

Applying mixin members of Library:'dart:collection' Class:
_LinkedHashMapMixin@600006304 to Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304 at pos 8528
Cloning constructor '_HashMap@600006304.' as
'_HashMap@600006304&&_LinkedHashMapMixin@600006304.'
Done applying mixin members of Library:'dart:collection' Class:
_LinkedHashMapMixin@600006304 to Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304
RemoveCHAOptimizedCode START Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304
* Library:'dart:collection' Class: _HashMap@600006304 [Library:'dart:collection'
Class: _HashMap@600006304&&_LinkedHashMapMixin@600006304]
Switching dart:_builtin_::__loadDataAsync@221999692 to unoptimized code because
CHA invalid (Library:'dart:collection' Class: _HashMap@600006304)
Switching dart:collection__HashMap@600006304_[] to unoptimized code because CHA
invalid (Library:'dart:collection' Class: _HashMap@600006304)
Switching dart:collection__HashMap@600006304_remove to unoptimized code because
CHA invalid (Library:'dart:collection' Class: _HashMap@600006304)
* Library:'dart:collection' Class: _LinkedHashMapMixin@600006304
[Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304]
RemoveCHAOptimizedCode END Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304

Without fix:

Applying mixin members of Library:'dart:collection' Class:
_LinkedHashMapMixin@600006304 to Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304 at pos 8528
Cloning constructor '_HashMap@600006304.' as
'_HashMap@600006304&&_LinkedHashMapMixin@600006304.'
Done applying mixin members of Library:'dart:collection' Class:
_LinkedHashMapMixin@600006304 to Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304
RemoveCHAOptimizedCode START Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304
* Library:'dart:collection' Class: _HashMap@600006304 [Library:'dart:collection'
Class: _HashMap@600006304&&_LinkedHashMapMixin@600006304]
* Library:'dart:collection' Class: _LinkedHashMapMixin@600006304
[Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304]
RemoveCHAOptimizedCode END Library:'dart:collection' Class:
_HashMap@600006304&&_LinkedHashMapMixin@600006304


Note that with my fix the remove method on HashMap is switched to unoptimized
code and the bug goes away. Without my fix affected methods are not switched to
unoptimized code.

[Cutch, 2015-01-14 17:03:49]

Committed patchset #3 (id:40001) manually as 42874 (presubmit successful).