When the file content is the same as the being removed overlay contents, ignore the change.

When the file content is the same as the being removed overlay contents, ignore the change.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=42833

[Brian Wilkerson, 2015-01-13 19:45:37]

LGTM, after comments are addressed.

https://codereview.chromium.org/845813006/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/845813006/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:3223: if (sourceEntry != null) {
We should get the source entry before reading, because there's no point reading
the file if the source isn't in the cache.

https://codereview.chromium.org/845813006/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:3224: sourceEntry.modificationTime =
getModificationStamp(source);
We should cache the content in the entry, and we should use the modification
stamp from 'getContents' rather than calling 'getModificationStamp'.

[scheglov, 2015-01-13 20:01:57]

https://codereview.chromium.org/845813006/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/845813006/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:3223: if (sourceEntry != null) {
On 2015/01/13 19:45:37, Brian Wilkerson wrote:
> We should get the source entry before reading, because there's no point
reading
> the file if the source isn't in the cache.

Done.

https://codereview.chromium.org/845813006/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:3224: sourceEntry.modificationTime =
getModificationStamp(source);
On 2015/01/13 19:45:37, Brian Wilkerson wrote:
> We should cache the content in the entry, and we should use the modification
> stamp from 'getContents' rather than calling 'getModificationStamp'.

Done.

[scheglov, 2015-01-13 20:02:45]

Committed patchset #2 (id:20001) manually as 42833 (presubmit successful).