Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 845793004: Update status files, replace "dartbug.com" with "Issue ". (Closed)

Created:
5 years, 11 months ago by Bill Hesse
Modified:
5 years, 11 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Update status files, replace "dartbug.com" with "Issue ". BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=42900

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove change to test_runner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -79 lines) Patch
M tests/co19/co19-dart2js.status View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/language.status View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 6 chunks +42 lines, -42 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/try/try.status View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/utils/utils.status View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bill Hesse
5 years, 11 months ago (2015-01-15 09:47:10 UTC) #2
ricow1
https://codereview.chromium.org/845793004/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/845793004/diff/1/tools/testing/dart/test_runner.dart#newcode1386 tools/testing/dart/test_runner.dart:1386: if (_rawOutcome == Expectation.RUNTIME_ERROR) return Expectation.PASS; why? https://codereview.chromium.org/845793004/diff/1/tools/testing/dart/test_runner.dart#newcode1387 tools/testing/dart/test_runner.dart:1387: ...
5 years, 11 months ago (2015-01-15 09:50:16 UTC) #3
Bill Hesse
Removed change to test_runner. https://codereview.chromium.org/845793004/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/845793004/diff/1/tools/testing/dart/test_runner.dart#newcode1386 tools/testing/dart/test_runner.dart:1386: if (_rawOutcome == Expectation.RUNTIME_ERROR) return ...
5 years, 11 months ago (2015-01-15 10:18:06 UTC) #4
ricow1
lgtm
5 years, 11 months ago (2015-01-15 10:22:21 UTC) #5
Bill Hesse
5 years, 11 months ago (2015-01-15 10:27:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698