Mute progress animation while Git is running so it doesn't overwrite credential prompts.

Mute progress animation while Git is running so it doesn't overwrite credential prompts.

BUG=https://code.google.com/p/dart/issues/detail?id=21839
R=jacobr@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42722

[Bob Nystrom, 2015-01-08 23:05:43]

rnystrom@google.com changed reviewers:
+ jacobr@google.com, nweiz@google.com

[Bob Nystrom, 2015-01-08 23:05:44]

I've tested this locally and the output is decent. You basically get this:

Resolving dependencies... Username for 'https://bitbucket.org': munificent
Password for 'https://munificent@bitbucket.org':
Resolving dependencies... (7.9s)
  analyzer 0.22.4 (0.23.0-dev.14 available)
  args 0.12.2+1
  barback 0.15.2+2
  browser 0.10.0+2

So the first line of the prompt appears at the end of the progress line. (It
will appear after the time too if there is any. There just wasn't any on my
test.) You can take your sweet time filling in the prompt. The password line
gets the next line. Then, when you fill that it starts back up on the next line.

I tried moving the cursor to the beginning of the line right before we call git
so that the first line appears at the beginning of the line, but I found the
flashing cursor to look annoying.

[Jacob, 2015-01-08 23:46:25]

lgtm

https://codereview.chromium.org/845543003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.chromium.org/845543003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/log.dart:407: _numMutes--;
nit:
consider adding

assert(_numMutes > 0);

[Bob Nystrom, 2015-01-08 23:58:19]

https://codereview.chromium.org/845543003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.chromium.org/845543003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/log.dart:407: _numMutes--;
On 2015/01/08 23:46:25, Jacob wrote:
> nit:
> consider adding
> 
> assert(_numMutes > 0); 
> 

Done.

[Bob Nystrom, 2015-01-08 23:58:42]

Committed patchset #1 (id:1) manually as 42722 (presubmit successful).

[Jacob, 2015-01-08 23:58:59]

lgtm