Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 844493005: Update cache size on analysis start/stop. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Update cache size on analysis start/stop. This reduces time of dart2js analysis after rename form 16000 ms to about 1200 ms, i.e. about 13 times ;-) R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 3 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 11 months ago (2015-01-15 20:51:44 UTC) #1
Brian Wilkerson
LGTM!
5 years, 11 months ago (2015-01-15 20:54:40 UTC) #2
scheglov
5 years, 11 months ago (2015-01-15 20:56:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42933 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698