Properly update git binary snapshots during pub upgrade.

Properly update git binary snapshots during pub upgrade.

Previously, the binaries were only updated if the version number had
changed. Now they're updated if just the commit changes. This also
improves the output of "pub upgrade" if a git dependency changes its
commit but not its version number.

R=rnystrom@google.com
BUG=21971
Committed: https://code.google.com/p/dart/source/detail?r=42883

[Bob Nystrom, 2015-01-13 17:18:41]

LGTM!

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:151:
packages.map((id) => sources[id.source].resolveId(id)));
I'm guessing this fixes this bug too:
https://code.google.com/p/dart/issues/detail?id=17788

?

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/test/g...
File sdk/lib/_internal/pub/test/get/git/check_out_and_upgrade_test.dart (right):

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/get/git/check_out_and_upgrade_test.dart:7: import
'package:scheduled_test/scheduled_test.dart';
Needed?

[nweiz, 2015-01-14 00:36:40]

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:151:
packages.map((id) => sources[id.source].resolveId(id)));
On 2015/01/13 17:18:41, Bob Nystrom wrote:
> I'm guessing this fixes this bug too:
> https://code.google.com/p/dart/issues/detail?id=17788
> 
> ?

Yep!

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/test/g...
File sdk/lib/_internal/pub/test/get/git/check_out_and_upgrade_test.dart (right):

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/get/git/check_out_and_upgrade_test.dart:7: import
'package:scheduled_test/scheduled_test.dart';
On 2015/01/13 17:18:41, Bob Nystrom wrote:
> Needed?

Yeah, it's how this file accesses [contains].

[Bob Nystrom, 2015-01-14 00:40:34]

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/test/g...
File sdk/lib/_internal/pub/test/get/git/check_out_and_upgrade_test.dart (right):

https://codereview.chromium.org/844263004/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/get/git/check_out_and_upgrade_test.dart:7: import
'package:scheduled_test/scheduled_test.dart';
On 2015/01/14 00:36:40, nweiz wrote:
> On 2015/01/13 17:18:41, Bob Nystrom wrote:
> > Needed?
> 
> Yeah, it's how this file accesses [contains].

Ah, I missed that the first time around.

[nweiz, 2015-01-14 01:21:24]

Turns out there were some tests I missed; PTAL

[Bob Nystrom, 2015-01-14 19:19:42]

lgtm

[nweiz, 2015-01-14 19:29:34]

Committed patchset #2 (id:20001) manually as 42883 (presubmit successful).