Consider updates of locals in type promotion.

Consider updates of locals in type promotion.

BUG= http://dartbug.com/21271
R=floitsch@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43062

[herhut, 2015-01-21 14:15:48]

Patchset #1 (id:1) has been deleted

[herhut, 2015-01-21 14:21:47]

I stumbled across this when working on better union computations on TypeMasks,
as more co19 tests started to fail...

[floitsch, 2015-01-21 14:34:03]

LGTM.

https://codereview.chromium.org/843613004/diff/20001/pkg/compiler/lib/src/inf...
File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right):

https://codereview.chromium.org/843613004/diff/20001/pkg/compiler/lib/src/inf...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:928: narrowed = new
LocalsHandler<T>.shallowCopyOf(locals);
Would it be better to just copy out the locals?

It reaches more into the privates of the LocalsHandler, but on the other hand it
is not completely clear now, what "shallow" involves.

https://codereview.chromium.org/843613004/diff/20001/pkg/compiler/lib/src/inf...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:935:
invalidatedInRightHandSide (Send test) {
bool invalidate ...
new line before and after.

[herhut, 2015-01-21 14:45:19]

https://codereview.chromium.org/843613004/diff/20001/pkg/compiler/lib/src/inf...
File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right):

https://codereview.chromium.org/843613004/diff/20001/pkg/compiler/lib/src/inf...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:928: narrowed = new
LocalsHandler<T>.shallowCopyOf(locals);
On 2015/01/21 14:34:02, floitsch wrote:
> Would it be better to just copy out the locals?
> 
> It reaches more into the privates of the LocalsHandler, but on the other hand
it
> is not completely clear now, what "shallow" involves.

It only copies the top level, so I have renamed it to topLevelCopyOf to make
that clear. Even if I only do the locals, I need a way to copy one level deep
there, so I prefer to just do it with the whole thing.

https://codereview.chromium.org/843613004/diff/20001/pkg/compiler/lib/src/inf...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:935:
invalidatedInRightHandSide (Send test) {
On 2015/01/21 14:34:02, floitsch wrote:
> bool invalidate ...
> new line before and after.

Done.

[herhut, 2015-01-22 09:52:38]

Committed patchset #2 (id:40001) manually as 43062 (presubmit successful).