Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 843503002: dart2js: Change name and comment of the flag needsArrayInitializerSupport. (Closed)

Created:
5 years, 11 months ago by zarah
Modified:
5 years, 11 months ago
Reviewers:
ahe, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Change name and comment of the flag needsArrayInitializerSupport. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=42685

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
zarah
5 years, 11 months ago (2015-01-07 13:48:31 UTC) #2
ahe
lgtm https://codereview.chromium.org/843503002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart (right): https://codereview.chromium.org/843503002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart#newcode193 pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:193: 'needsArrayInitializerSupport': oldEmitter.needsStructuredMemberInfo}); Also rename needsArrayInitializerSupport?
5 years, 11 months ago (2015-01-07 14:00:05 UTC) #3
zarah
https://codereview.chromium.org/843503002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart (right): https://codereview.chromium.org/843503002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart#newcode193 pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:193: 'needsArrayInitializerSupport': oldEmitter.needsStructuredMemberInfo}); On 2015/01/07 14:00:05, ahe wrote: > Also ...
5 years, 11 months ago (2015-01-07 14:05:43 UTC) #4
ahe
lgtm
5 years, 11 months ago (2015-01-07 14:16:50 UTC) #5
zarah
5 years, 11 months ago (2015-01-08 10:28:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42685 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698