Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 843163002: Fixes for linked and exit positions offsets. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fixes for linked and exit positions offsets. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42757

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -160 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 3 chunks +161 lines, -160 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 11 months ago (2015-01-09 22:15:35 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/843163002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart File pkg/analysis_server/lib/src/services/correction/assist_internal.dart (right): https://codereview.chromium.org/843163002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart#newcode1422 pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1422: sb.append("$indentOld}"); nit: It's probably just me, but it ...
5 years, 11 months ago (2015-01-09 22:23:03 UTC) #2
scheglov
https://codereview.chromium.org/843163002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart File pkg/analysis_server/lib/src/services/correction/assist_internal.dart (right): https://codereview.chromium.org/843163002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart#newcode1422 pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1422: sb.append("$indentOld}"); On 2015/01/09 22:23:02, Brian Wilkerson wrote: > nit: ...
5 years, 11 months ago (2015-01-09 22:31:19 UTC) #3
scheglov
5 years, 11 months ago (2015-01-09 22:31:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698