x64 port of r42717.

x64 port of r42717.

Committed: https://code.google.com/p/dart/source/detail?r=42723

[Ivan Posva, 2015-01-09 00:16:56]

LGTMwC

-Ivan

https://codereview.chromium.org/842953002/diff/20001/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/842953002/diff/20001/runtime/vm/assembler_x64...
runtime/vm/assembler_x64.cc:3067: void Assembler::VerifyUninitialized(const
Address& dest) {
Missed this in the original review:

#if defined(DEBUG)
  ...
#else
#error Only supported in DEBUG.
#endif  // defined(DEBUG)

Since this code will not work unless it is called in DEBUG due to unzapped
values.

[koda, 2015-01-09 02:02:34]

https://codereview.chromium.org/842953002/diff/20001/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/842953002/diff/20001/runtime/vm/assembler_x64...
runtime/vm/assembler_x64.cc:3067: void Assembler::VerifyUninitialized(const
Address& dest) {
On 2015/01/09 00:16:56, Ivan Posva wrote:
> Missed this in the original review:
> 
> #if defined(DEBUG)
>   ...
> #else
> #error Only supported in DEBUG.
> #endif  // defined(DEBUG)
> 
> Since this code will not work unless it is called in DEBUG due to unzapped
> values.

Done.

[koda, 2015-01-09 02:04:35]

Committed patchset #2 (id:20001) manually as r42723 (presubmit successful).

[regis, 2015-01-09 02:21:49]

regis@google.com changed reviewers:
+ regis@google.com

[regis, 2015-01-09 02:21:50]

Please add an assembler test for each new instruction.
I know, I know, I hate to do it too...