Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 842503003: Enable async support (Closed)

Created:
5 years, 11 months ago by Brian Wilkerson
Modified:
5 years, 11 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -143 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java View 3 chunks +5 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/context/AnalysisOptionsImplTest.java View 3 chunks +1 line, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/options.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 7 chunks +9 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +14 lines, -33 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 20 chunks +0 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 3 chunks +0 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 10 chunks +0 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M pkg/analyzer/test/options_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
This removes the need for the --enable-async flag by always enabling support. I cleaned up ...
5 years, 11 months ago (2015-01-06 22:39:24 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-06 22:44:24 UTC) #3
danrubel
lgtm
5 years, 11 months ago (2015-01-06 23:54:16 UTC) #4
Brian Wilkerson
5 years, 11 months ago (2015-01-07 16:51:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698