Linter analyzer plumbing.

Linter analyzer plumbing.

R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42701

[pquitslund, 2015-01-07 20:01:46]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

[pquitslund, 2015-01-07 20:01:47]

Ready for feedback.

Tests pass as-is but a next step is making them lint-aware (and of course
testing an actual lint rule implementation).

Any and all comments welcome!

[danrubel, 2015-01-07 20:17:58]

LGTM

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:2677: * [CacheStateERROR]. This
method assumes that the data can be produced by generating hints
hints -> lints

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:3283: * Create a
[GenerateDartHintsTask] for the given source, marking the hints as being
hint -> lint in 2 places

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:3625: * be produced by generating
hints for the library if it is not already cached.
hint -> lint

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:4818: "GenerateDartHintsTask returned
a null lint map "
Hint -> Lint

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:5535:
dartEntry.hasInvalidData(DartEntry.HINTS) ||
HINTS -> LINTS
Plus perhaps a test?

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:9546: * @param librarySource the
source of the library in which hints were being generated
hint -> lint

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:982:
timer.stop('generate hints');
hint -> lint

[scheglov, 2015-01-07 21:19:24]

lgtm

[Brian Wilkerson, 2015-01-07 23:57:54]

LGTM

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:2730: dartEntry = new
GenerateDartLintsTask(
This is fine for now, but unless you're going to have lints that need
information for all of the compilation units in the library at the same time
(hints does because of the dead code analysis) we should rework this to operate
on a single compilation unit at a time. (A TODO might be a good idea so we don't
forget.)

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:3322: new GenerateDartLintsTask(this,
units, libraryElement),
Ditto

[pquitslund, 2015-01-08 00:29:52]

Thanks for all the feedback and proofing.

I'll follow up with some tests tomorrow.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:2677: * [CacheStateERROR]. This
method assumes that the data can be produced by generating hints
On 2015/01/07 20:17:57, danrubel wrote:
> hints -> lints

Done.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:2730: dartEntry = new
GenerateDartLintsTask(
On 2015/01/07 23:57:54, Brian Wilkerson wrote:
> This is fine for now, but unless you're going to have lints that need
> information for all of the compilation units in the library at the same time
> (hints does because of the dead code analysis) we should rework this to
operate
> on a single compilation unit at a time. (A TODO might be a good idea so we
don't
> forget.)

Konstantin and I chatted about this and thought it wouldn't hurt to have the
context.  That said, you may well be right that we won't need it...  I'll add a
TODO to revisit.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:3283: * Create a
[GenerateDartHintsTask] for the given source, marking the hints as being
On 2015/01/07 20:17:57, danrubel wrote:
> hint -> lint in 2 places

Done.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:3322: new GenerateDartLintsTask(this,
units, libraryElement),
On 2015/01/07 23:57:54, Brian Wilkerson wrote:
> Ditto

Done.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:3625: * be produced by generating
hints for the library if it is not already cached.
On 2015/01/07 20:17:57, danrubel wrote:
> hint -> lint

Done.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:4818: "GenerateDartHintsTask returned
a null lint map "
On 2015/01/07 20:17:57, danrubel wrote:
> Hint -> Lint

Done.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:5535:
dartEntry.hasInvalidData(DartEntry.HINTS) ||
On 2015/01/07 20:17:57, danrubel wrote:
> HINTS -> LINTS
> Plus perhaps a test?

Great catch.  Thanks!

Tests to follow in the next CL.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/engine.dart:9546: * @param librarySource the
source of the library in which hints were being generated
On 2015/01/07 20:17:57, danrubel wrote:
> hint -> lint

Done.

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/841813002/diff/50001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:982:
timer.stop('generate hints');
On 2015/01/07 20:17:57, danrubel wrote:
> hint -> lint

Done.

[pquitslund, 2015-01-08 17:09:15]

Committed patchset #4 (id:50001) manually as r42701 (presubmit successful).