Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 841653004: Recover from read errors. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/recover_from_read_only
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status file. #

Patch Set 3 : Merged with r42871 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -44 lines) Patch
M dart/pkg/compiler/lib/src/apiimpl.dart View 2 chunks +27 lines, -10 lines 0 comments Download
M dart/pkg/compiler/lib/src/compiler.dart View 4 chunks +13 lines, -7 lines 0 comments Download
M dart/pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/library_loader.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M dart/pkg/compiler/lib/src/script.dart View 1 chunk +6 lines, -1 line 0 comments Download
M dart/pkg/compiler/lib/src/source_file_provider.dart View 2 chunks +9 lines, -4 lines 0 comments Download
M dart/pkg/compiler/lib/src/warnings.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/import_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M dart/tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/missing_file_test.dart View 2 chunks +16 lines, -11 lines 0 comments Download
M dart/tests/compiler/dart2js/package_root_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
5 years, 11 months ago (2015-01-14 13:15:09 UTC) #2
Johnni Winther
LGTM thanks!
5 years, 11 months ago (2015-01-14 13:27:55 UTC) #3
ahe
PTAL at status file changes. I have already fixed the crash, but I think that ...
5 years, 11 months ago (2015-01-14 14:14:53 UTC) #4
ahe
Committed patchset #3 (id:40001) manually as 42872 (presubmit successful).
5 years, 11 months ago (2015-01-14 14:16:22 UTC) #5
Johnni Winther
5 years, 11 months ago (2015-01-15 08:05:40 UTC) #6
Message was sent while issue was closed.
Still lgtm

Powered by Google App Engine
This is Rietveld 408576698