Issue 841343002: ARM port of r42723.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 841343002: ARM port of r42723. (Closed)

Created:
5 years, 11 months ago by koda

Modified:
5 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

ARM port of r42723. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42962

Patch Set 3 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -66 lines)			Patch
M	runtime/vm/assembler_arm.h	View		4 chunks	+33 lines, -10 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2	6 chunks	+82 lines, -37 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		5 chunks	+11 lines, -7 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/841343002/diff/20001/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/841343002/diff/20001/runtime/vm/assembler_arm.cc#newcode1713 runtime/vm/assembler_arm.cc:1713: if (address.rm() != kNoRegister) UseRegister(address.rm(), &used); { ...

5 years, 11 months ago (2015-01-16 06:34:48 UTC) #2

koda

https://codereview.chromium.org/841343002/diff/20001/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/841343002/diff/20001/runtime/vm/assembler_arm.cc#newcode1713 runtime/vm/assembler_arm.cc:1713: if (address.rm() != kNoRegister) UseRegister(address.rm(), &used); On 2015/01/16 06:34:48, ...

5 years, 11 months ago (2015-01-16 16:24:33 UTC) #3

koda

5 years, 11 months ago (2015-01-16 16:51:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r42962 (presubmit successful).

Expand Messages | Collapse Messages

Issue 841343002: ARM port of r42723. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages