Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840723003: Recover from crash in xcodebuild/ReleaseIA32/generated_tests/language/async_test_constructor4.dart. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/recover_crash
Visibility:
Public.

Description

Recover from crash in language/async_test/constructor4. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42904

Patch Set 1 #

Patch Set 2 : Fixed issues in tests. #

Total comments: 2

Patch Set 3 : Merged with r42903. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -6 lines) Patch
M dart/pkg/compiler/lib/src/compile_time_constants.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/elements/modelx.dart View 1 2 chunks +73 lines, -1 line 0 comments Download
M dart/pkg/compiler/lib/src/resolution/members.dart View 1 2 4 chunks +11 lines, -4 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
ahe
5 years, 11 months ago (2015-01-14 14:27:22 UTC) #2
ahe
Ignore this for now. Testing reveals further complications.
5 years, 11 months ago (2015-01-14 14:35:20 UTC) #3
ahe
Ready for review, all tests are passing.
5 years, 11 months ago (2015-01-14 16:23:36 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/840723003/diff/20001/dart/pkg/compiler/lib/src/compile_time_constants.dart File dart/pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/840723003/diff/20001/dart/pkg/compiler/lib/src/compile_time_constants.dart#newcode957 dart/pkg/compiler/lib/src/compile_time_constants.dart:957: if (constructor.isErroneous) return; Shouldn't we generate an ErroneousConstantExpression ...
5 years, 11 months ago (2015-01-15 09:31:48 UTC) #5
ahe
Committed patchset #3 (id:40001) manually as 42904 (presubmit successful).
5 years, 11 months ago (2015-01-15 12:04:41 UTC) #6
ahe
5 years, 11 months ago (2015-01-15 12:07:21 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/840723003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/840723003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/compile_time_constants.dart:957: if
(constructor.isErroneous) return;
On 2015/01/15 09:31:48, Johnni Winther wrote:
> Shouldn't we generate an ErroneousConstantExpression for the constructed
object
> instead?

I'll look at that in a follow up.

Powered by Google App Engine
This is Rietveld 408576698