Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 840563005: dart2js: Use is-checks from the model in the old emitter. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Use is-checks from the model in the old emitter. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43065

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -46 lines) Patch
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 chunks +16 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 2 chunks +13 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 3 chunks +2 lines, -3 lines 0 comments Download
D pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 4 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 11 months ago (2015-01-21 20:13:14 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-22 07:59:43 UTC) #3
floitsch
5 years, 11 months ago (2015-01-22 10:26:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698