Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 840553002: dart2js: Add elements to the emitter's model. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Add elements to the emitter's model. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -25 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 7 chunks +44 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 11 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 11 months ago (2015-01-06 13:19:36 UTC) #2
floitsch
I would like to remove the field soonish, but this seems to be the fastest ...
5 years, 11 months ago (2015-01-06 13:20:11 UTC) #3
zarah
LGTM!
5 years, 11 months ago (2015-01-06 13:26:25 UTC) #4
floitsch
5 years, 11 months ago (2015-01-06 17:25:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42638 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698