Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840133003: matcher: fixed status file, formatting, tweaks to readme (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/matcher.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

matcher: fixed status file, formatting, tweaks to readme R=sigmund@google.com Committed: https://github.com/dart-lang/matcher/commit/0d23f15ab41b21c0d23037e7cf7c23a154e52916

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+559 lines, -601 lines) Patch
M .status View 2 chunks +1 line, -11 lines 0 comments Download
M README.md View 1 chunk +2 lines, -2 lines 0 comments Download
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M lib/mirror_matchers.dart View 3 chunks +12 lines, -9 lines 0 comments Download
M lib/src/core_matchers.dart View 13 chunks +49 lines, -45 lines 0 comments Download
M lib/src/description.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/error_matchers.dart View 10 chunks +11 lines, -16 lines 0 comments Download
M lib/src/expect.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M lib/src/future_matchers.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M lib/src/interfaces.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/iterable_matchers.dart View 8 chunks +45 lines, -44 lines 0 comments Download
M lib/src/map_matchers.dart View 1 chunk +16 lines, -11 lines 0 comments Download
M lib/src/numeric_matchers.dart View 6 chunks +46 lines, -57 lines 0 comments Download
M lib/src/operator_matchers.dart View 1 5 chunks +23 lines, -33 lines 0 comments Download
M lib/src/pretty_print.dart View 1 3 chunks +21 lines, -16 lines 0 comments Download
M lib/src/prints_matcher.dart View 3 chunks +7 lines, -6 lines 0 comments Download
M lib/src/string_matchers.dart View 4 chunks +17 lines, -19 lines 0 comments Download
M lib/src/throws_matcher.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/core_matchers_test.dart View 4 chunks +35 lines, -22 lines 0 comments Download
M test/future_matchers_test.dart View 5 chunks +11 lines, -11 lines 0 comments Download
M test/iterable_matchers_test.dart View 6 chunks +23 lines, -28 lines 0 comments Download
M test/matchers_minified_test.dart View 3 chunks +58 lines, -60 lines 0 comments Download
M test/matchers_unminified_test.dart View 2 chunks +57 lines, -59 lines 0 comments Download
M test/mirror_matchers_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/numeric_matchers_test.dart View 6 chunks +33 lines, -42 lines 0 comments Download
M test/operator_matchers_test.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M test/pretty_print_test.dart View 4 chunks +16 lines, -21 lines 0 comments Download
M test/pretty_print_unminified_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M test/prints_matcher_test.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M test/string_matchers_test.dart View 3 chunks +15 lines, -15 lines 0 comments Download
M test/test_common.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/test_utils.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M test/throws_matchers_test.dart View 3 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 11 months ago (2015-01-14 20:02:03 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/840133003/diff/1/lib/src/operator_matchers.dart File lib/src/operator_matchers.dart (right): https://codereview.chromium.org/840133003/diff/1/lib/src/operator_matchers.dart#newcode30 lib/src/operator_matchers.dart:30: Matcher allOf(arg0, [arg1 = null, arg2 = null, ...
5 years, 11 months ago (2015-01-14 20:30:09 UTC) #3
kevmoo
https://codereview.chromium.org/840133003/diff/1/lib/src/operator_matchers.dart File lib/src/operator_matchers.dart (right): https://codereview.chromium.org/840133003/diff/1/lib/src/operator_matchers.dart#newcode30 lib/src/operator_matchers.dart:30: Matcher allOf(arg0, [arg1 = null, arg2 = null, arg3 ...
5 years, 11 months ago (2015-01-14 22:28:45 UTC) #4
kevmoo
5 years, 11 months ago (2015-01-14 22:28:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0d23f15ab41b21c0d23037e7cf7c23a154e52916 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698