dart2js: Use unique instance as exit signal.

dart2js: Use unique instance as exit signal.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42806

[floitsch, 2015-01-12 14:32:52]

floitsch@google.com changed reviewers:
+ ahe@google.com

[floitsch, 2015-01-12 14:32:52]

Hopefully fixes issue 21926.

[ahe, 2015-01-13 08:35:20]

lgtm

I don't think this fixes https://code.google.com/p/dart/issues/detail?id=21926

But it does use a unique instance which is an improvement by itself.

https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
pkg/compiler/lib/src/dart2js.dart:429: fail('Compilation failed.');
This throws _EXIT_SIGNAL.

https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
pkg/compiler/lib/src/dart2js.dart:661: print(trace);
This prints the stack trace associated with _EXIT_SIGNAL.

https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
pkg/compiler/lib/src/dart2js.dart:670: return
compilerMain(arguments).catchError(onError);
This calls compile which calls compilationDone.

https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
pkg/compiler/lib/src/dart2js.dart:703: return internalMain(args);
Calling internalMain here.

[floitsch, 2015-01-13 13:51:10]

On 2015/01/13 08:35:20, ahe wrote:
> lgtm
> 
> I don't think this fixes https://code.google.com/p/dart/issues/detail?id=21926
> 
> But it does use a unique instance which is an improvement by itself.
> 
>
https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
> File pkg/compiler/lib/src/dart2js.dart (right):
> 
>
https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
> pkg/compiler/lib/src/dart2js.dart:429: fail('Compilation failed.');
> This throws _EXIT_SIGNAL.
> 
>
https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
> pkg/compiler/lib/src/dart2js.dart:661: print(trace);
> This prints the stack trace associated with _EXIT_SIGNAL.
> 
>
https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
> pkg/compiler/lib/src/dart2js.dart:670: return
> compilerMain(arguments).catchError(onError);
> This calls compile which calls compilationDone.
> 
>
https://codereview.chromium.org/840013003/diff/1/pkg/compiler/lib/src/dart2js...
> pkg/compiler/lib/src/dart2js.dart:703: return internalMain(args);
> Calling internalMain here.

I might look into fixing the bug eventually.
For now just creating the unique instance.

[floitsch, 2015-01-13 13:51:36]

Committed patchset #1 (id:1) manually as 42806 (presubmit successful).