Initial plugin API

Initial plugin API

R=danrubel@google.com, pquitslund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42736

[danrubel, 2015-01-08 19:46:36]

danrubel@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2015-01-08 19:46:37]

lgtm

https://codereview.chromium.org/839833002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/plugin/plugin_impl.dart (right):

https://codereview.chromium.org/839833002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/plugin/plugin_impl.dart:31: for (Plugin plugin in
plugins) {
Do we want to validate that none of the plugins in the list has a conflicting
uniqueIdentifier? Or is that done elsewhere?

[scheglov, 2015-01-08 19:49:12]

LGTM

[Brian Wilkerson, 2015-01-08 22:00:54]

https://codereview.chromium.org/839833002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/plugin/plugin_impl.dart (right):

https://codereview.chromium.org/839833002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/plugin/plugin_impl.dart:31: for (Plugin plugin in
plugins) {
> Do we want to validate that none of the plugins in the list has a conflicting
> uniqueIdentifier? Or is that done elsewhere?

Good question. I'm tempted to check at the point at which the list of plugins is
being set so that we fail faster when there's a problem. (I'm guessing that we
want any kind of error related to plugins to stop the server.

[pquitslund, 2015-01-08 23:30:05]

pquitslund@google.com changed reviewers:
+ pquitslund@google.com

[pquitslund, 2015-01-08 23:30:06]

Fantastic!

High-level question.  For the purposes of linter plugins I'd really like to be
able to plug into the analyzer (not server). Given that, might it make more
sense for the plugin abstractions to live there?  Or, perhaps better still, move
them into their own package?  (I know that's the mid-term plan, but maybe sooner
is better?)

[pquitslund, 2015-01-08 23:30:44]

On 2015/01/08 23:30:06, pquitslund wrote:
> Fantastic!
> 
> High-level question.  For the purposes of linter plugins I'd really like to be
> able to plug into the analyzer (not server). Given that, might it make more
> sense for the plugin abstractions to live there?  Or, perhaps better still,
move
> them into their own package?  (I know that's the mid-term plan, but maybe
sooner
> is better?)

Needless to say, LGTM! :)

[Brian Wilkerson, 2015-01-08 23:57:20]

> I'd really like to be able to plug into the analyzer (not server).
> Given that, might it make more sense for the plugin abstractions
> to live there?

Good question. That might make sense, but there are enough unanswered questions
in my mind about how plugins would get installed in engine that I'm not sure. In
the end I decided that it would be easier to push the functionality down into
engine (or a separate package) than to pull it up if we decided that we didn't
need/want to use the same mechanism for engine. Hence the current location. I
expect we'll know fairly soon after we start building the API for plugging into
the engine.

[pquitslund, 2015-01-09 00:17:56]

On 2015/01/08 23:57:20, Brian Wilkerson wrote:
> > I'd really like to be able to plug into the analyzer (not server).
> > Given that, might it make more sense for the plugin abstractions
> > to live there?
> 
> Good question. That might make sense, but there are enough unanswered
questions
> in my mind about how plugins would get installed in engine that I'm not sure.
In
> the end I decided that it would be easier to push the functionality down into
> engine (or a separate package) than to pull it up if we decided that we didn't
> need/want to use the same mechanism for engine. Hence the current location. I
> expect we'll know fairly soon after we start building the API for plugging
into
> the engine.

Sounds good. In the meantime, I'll pursue the angle we discussed this AM (which
is to say, a separate imported package with contributions explicitly added).

[Brian Wilkerson, 2015-01-09 15:58:02]

Committed patchset #3 (id:40001) manually as 42736 (presubmit successful).