Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 839633004: Improve performance of table trees by around 3x (Closed)

Created:
5 years, 11 months ago by Cutch
Modified:
5 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Improve performance of table trees by around 3x *) Stop using Polymer's template repeat for building table trees. *) Refactor TableTree and TableTreeRow to be easier to use without template repeat. *) Port class tree to new TableTree interface. *) Rename isolate-profile to cpu-profile. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=42755

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -592 lines) Patch
M runtime/observatory/lib/elements.dart View 2 chunks +1 line, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/view_model.dart View 1 2 4 chunks +110 lines, -31 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.dart View 3 chunks +22 lines, -49 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.html View 1 chunk +2 lines, -11 lines 0 comments Download
A + runtime/observatory/lib/src/elements/cpu_profile.dart View 8 chunks +77 lines, -56 lines 0 comments Download
A + runtime/observatory/lib/src/elements/cpu_profile.html View 2 chunks +4 lines, -38 lines 0 comments Download
D runtime/observatory/lib/src/elements/isolate_profile.dart View 1 chunk +0 lines, -210 lines 0 comments Download
D runtime/observatory/lib/src/elements/isolate_profile.html View 1 chunk +0 lines, -192 lines 0 comments Download
M runtime/observatory/lib/src/elements/observatory_element.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/observatory.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 11 months ago (2015-01-09 20:40:22 UTC) #2
rmacnak
LGTM https://codereview.chromium.org/839633004/diff/1/runtime/observatory/lib/src/app/view_model.dart File runtime/observatory/lib/src/app/view_model.dart (right): https://codereview.chromium.org/839633004/diff/1/runtime/observatory/lib/src/app/view_model.dart#newcode52 runtime/observatory/lib/src/app/view_model.dart:52: String _colorForRow() { classForRow?
5 years, 11 months ago (2015-01-09 21:55:51 UTC) #3
Cutch
https://codereview.chromium.org/839633004/diff/1/runtime/observatory/lib/src/app/view_model.dart File runtime/observatory/lib/src/app/view_model.dart (right): https://codereview.chromium.org/839633004/diff/1/runtime/observatory/lib/src/app/view_model.dart#newcode52 runtime/observatory/lib/src/app/view_model.dart:52: String _colorForRow() { On 2015/01/09 21:55:50, rmacnak wrote: > ...
5 years, 11 months ago (2015-01-09 22:00:42 UTC) #4
Cutch
5 years, 11 months ago (2015-01-09 22:03:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 42755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698