Handle platform access through prefix in dart2dart

Handle platform access through prefix in dart2dart

BUG=
R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42726

[Johnni Winther, 2015-01-08 14:25:43]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Johnni Winther, 2015-01-09 09:38:55]

Uploaded a new patch.

[sigurdm, 2015-01-09 09:51:52]

LGTM

https://codereview.chromium.org/839063002/diff/20001/pkg/compiler/lib/src/dar...
File pkg/compiler/lib/src/dart_backend/outputter.dart (right):

https://codereview.chromium.org/839063002/diff/20001/pkg/compiler/lib/src/dar...
pkg/compiler/lib/src/dart_backend/outputter.dart:526: if
(library.isPlatformLibrary && !library.isInternalLibrary) {
Can the library ever be internal?

https://codereview.chromium.org/839063002/diff/20001/pkg/compiler/lib/src/dar...
pkg/compiler/lib/src/dart_backend/outputter.dart:527:
mainUnparser.unparseImportTag(library.canonicalUri.toString());
Add comment explaining we're making two imports - one with and one without the
prefix, as this might be unintuitive

[Johnni Winther, 2015-01-09 10:21:19]

https://codereview.chromium.org/839063002/diff/20001/pkg/compiler/lib/src/dar...
File pkg/compiler/lib/src/dart_backend/outputter.dart (right):

https://codereview.chromium.org/839063002/diff/20001/pkg/compiler/lib/src/dar...
pkg/compiler/lib/src/dart_backend/outputter.dart:526: if
(library.isPlatformLibrary && !library.isInternalLibrary) {
On 2015/01/09 09:51:52, sigurdm wrote:
> Can the library ever be internal?

No. That would be an internal error. Changed the test into an assert.

https://codereview.chromium.org/839063002/diff/20001/pkg/compiler/lib/src/dar...
pkg/compiler/lib/src/dart_backend/outputter.dart:527:
mainUnparser.unparseImportTag(library.canonicalUri.toString());
On 2015/01/09 09:51:52, sigurdm wrote:
> Add comment explaining we're making two imports - one with and one without the
> prefix, as this might be unintuitive

Done.

[Johnni Winther, 2015-01-09 10:30:39]

Committed patchset #3 (id:40001) manually as 42726 (presubmit successful).