Issue 838863004: Handle LoadClassId(obj) === cid during type propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 838863004: Handle LoadClassId(obj) === cid during type propagation. (Closed)

Created:
5 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Handle LoadClassId(obj) === cid during type propagation. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=42779

Patch Set 2 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -14 lines)			Patch
M	runtime/vm/flow_graph_type_propagator.cc	View	1	2 chunks	+28 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+29 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

https://codereview.chromium.org/838863004/diff/1/runtime/vm/flow_graph_type_propagator.cc File runtime/vm/flow_graph_type_propagator.cc (right): https://codereview.chromium.org/838863004/diff/1/runtime/vm/flow_graph_type_propagator.cc#newcode179 runtime/vm/flow_graph_type_propagator.cc:179: if (defn->IsLoadClassId() && right.IsSmi()) { Please make sure externalizable ...

5 years, 11 months ago (2015-01-12 16:47:37 UTC) #2

Vyacheslav Egorov (Google)

5 years, 11 months ago (2015-01-12 17:25:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42779 (presubmit successful).

Expand Messages | Collapse Messages

Issue 838863004: Handle LoadClassId(obj) === cid during type propagation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages