Fix for the DeltaProcessing event when a user changes a library name, inside of a #library(..). I...

Fix for the DeltaProcessing event when a user changes a library name, inside of a #library(..). If there is no such library directive, the assumed name of the library is the name of the defining-CompilationUnit file.

This fixes Issue 133: http://code.google.com/p/dart/issues/detail?id=133
Committed: https://code.google.com/p/dart/source/detail?r=657

[jwren, 2011-10-24 20:54:49]

http://codereview.chromium.org/8387002/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/delta/DeltaProcessor.java
(right):

http://codereview.chromium.org/8387002/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/delta/DeltaProcessor.java:1030:
// way from DartLibraryImpl#getDisplayName()
This is brittle- if DartLibraryImpl#getDisplayName() changes the way that the
implicit name of the library is constructed, this code will be out-dated.  Any
objection to creating a method with the following signature in DartLibraryImpl?:

/**
 * This method is called when there is no Library directive to specify the name
of a library.
 */
public static String getImplicitLibraryName();

This method would be called here instead, and also at the end of
DartLibraryImpl#getDisplayName().

[Brian Wilkerson, 2011-10-24 22:03:56]

http://codereview.chromium.org/8387002/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/delta/DeltaProcessor.java
(right):

http://codereview.chromium.org/8387002/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/delta/DeltaProcessor.java:1030:
// way from DartLibraryImpl#getDisplayName()
> Any objection to creating a method with the following signature...

Absolutely none. That looks like the right way to address the problem.

[Brian Wilkerson, 2011-10-24 22:17:55]

http://codereview.chromium.org/8387002/diff/4004/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java
(right):

http://codereview.chromium.org/8387002/diff/4004/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java:107:
public static String getImplicitLibraryName(DartLibraryImpl library) {
Why is this a static method?

[Brian Wilkerson, 2011-10-24 22:18:18]

LGTM

[jwren, 2011-10-24 22:21:57]

http://codereview.chromium.org/8387002/diff/4004/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java
(right):

http://codereview.chromium.org/8387002/diff/4004/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java:107:
public static String getImplicitLibraryName(DartLibraryImpl library) {
On 2011/10/24 22:17:55, Brian Wilkerson wrote:
> Why is this a static method?

It doesn't need to be static, I don't know why I put it in as static, changing
it before a commit....