Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 838693002: Fix compilation warnings in Windows event handler (Closed)

Created:
5 years, 11 months ago by Cutch
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix compilation warnings in Windows event handler BUG= Committed: https://code.google.com/p/dart/source/detail?r=42649

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M runtime/bin/eventhandler_win.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_win.cc View 2 chunks +0 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
Cutch
See warnings here: http://build.chromium.org/p/client.dart/builders/dartium-win-inc-ninja-be/builds/6161/steps/compile/logs/stdio
5 years, 11 months ago (2015-01-06 22:48:43 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as 42649.
5 years, 11 months ago (2015-01-06 22:51:05 UTC) #3
Cutch
TBR
5 years, 11 months ago (2015-01-06 22:51:10 UTC) #4
Cutch
+ajohnsen: PTAL
5 years, 11 months ago (2015-01-06 23:00:20 UTC) #6
Ivan Posva
LGTM -ip https://codereview.chromium.org/838693002/diff/1/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (left): https://codereview.chromium.org/838693002/diff/1/runtime/bin/eventhandler_win.cc#oldcode713 runtime/bin/eventhandler_win.cc:713: DWORD bytes_written = -1; Interestingly this was ...
5 years, 11 months ago (2015-01-06 23:27:45 UTC) #7
Anders Johnsen
5 years, 11 months ago (2015-01-07 08:36:13 UTC) #8
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698