dart2js: Register constants in the model builder.

dart2js: Register constants in the model builder.

We need to make sure that constants are registered, as otherwise output units that only contain constants aren't generated.

R=zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42743

[floitsch, 2015-01-07 17:02:18]

floitsch@google.com changed reviewers:
+ zarah@google.com

[zarah, 2015-01-09 08:39:20]

LGTM

https://codereview.chromium.org/838643002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/registry.dart (right):

https://codereview.chromium.org/838643002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/registry.dart:85: if (targetUnit ==
_mainOutputUnit) return mainFragment;
Shouldn't _lastOutputUnit and _lastFragment be set in this case too?

[floitsch, 2015-01-09 17:21:50]

https://codereview.chromium.org/838643002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/registry.dart (right):

https://codereview.chromium.org/838643002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/registry.dart:85: if (targetUnit ==
_mainOutputUnit) return mainFragment;
On 2015/01/09 08:39:19, zarah wrote:
> Shouldn't _lastOutputUnit and _lastFragment be set in this case too?

done and simplified.

[floitsch, 2015-01-09 17:22:50]

Committed patchset #2 (id:20001) manually as 42743 (presubmit successful).