Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 838283002: Adds LINTs to the server's generated protocol. (Closed)

Created:
5 years, 11 months ago by pquitslund
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
5 years, 11 months ago (2015-01-08 19:02:00 UTC) #2
pquitslund
5 years, 11 months ago (2015-01-08 19:03:58 UTC) #4
scheglov
LGTM!
5 years, 11 months ago (2015-01-08 19:04:51 UTC) #5
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-08 19:05:10 UTC) #6
pquitslund
5 years, 11 months ago (2015-01-08 19:05:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698