Issue 838173002: Make the observatory building be dependent on the pkg_packages target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 838173002: Make the observatory building be dependent on the pkg_packages target (Closed)

Created:
5 years, 11 months ago by ricow1

Modified:
5 years, 11 months ago

Reviewers:
Cutch, Mads Ager (google)

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make the observatory building be dependent on the pkg_packages target With the current setup (as of revision 42679), a clean build of: tools/build.py -mrelease build_observatory Will throw an error since the args packages has not yet been symlinked into the out/ReleaseIA32/packages location. R=ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=42683

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/observatory/observatory.gypi	View		3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

Committed patchset #2 (id:20001) manually as r42683 (presubmit successful).

5 years, 11 months ago (2015-01-08 09:59:07 UTC) #4

Cutch

5 years, 11 months ago (2015-01-08 15:39:48 UTC) #5

Message was sent while issue was closed.

On 2015/01/08 09:59:07, ricow1 wrote:
> Committed patchset #2 (id:20001) manually as r42683 (presubmit successful).

lgtm and thanks!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages