Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 838163002: Ensure packageRoot is non-null in docgen. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Alan Knight, Emily Fortuna, kevmoo
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Ensure packageRoot is non-null in docgen. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M dart/pkg/docgen/lib/src/generator.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ahe
5 years, 11 months ago (2015-01-08 09:16:28 UTC) #2
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-08 09:48:54 UTC) #3
ahe
5 years, 11 months ago (2015-01-08 09:56:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698