Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 837903002: Fix deferred loading with multiple apps on same page. (Closed)

Created:
5 years, 11 months ago by sigurdm
Modified:
5 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix deferred loading with multiple apps on same page. Even though two apps don't have to load a file twice, they still both have to initialize it. Still missing this support for the new emitter. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42660

Patch Set 1 #

Patch Set 2 : Cleanup js-generation #

Total comments: 4

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -24 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 2 chunks +28 lines, -16 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tests/html/deferred_multi_app.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/html/deferred_multi_app_htmltest.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + tests/html/deferred_multi_app_lib.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/html/html.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sigurdm
5 years, 11 months ago (2015-01-07 12:09:09 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/837903002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/837903002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode1832 pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1832: buffer.write(jsAst.prettyPrint( Put all these statements together into one ...
5 years, 11 months ago (2015-01-07 13:04:32 UTC) #3
sigurdm
https://codereview.chromium.org/837903002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/837903002/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode1832 pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1832: buffer.write(jsAst.prettyPrint( On 2015/01/07 13:04:31, floitsch wrote: > Put all ...
5 years, 11 months ago (2015-01-07 13:37:13 UTC) #4
sigurdm
5 years, 11 months ago (2015-01-07 14:06:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698