Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 837563004: Address comments from 820093006 (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther, zarah
CC:
reviews_dartlang.org
Target Ref:
refs/heads/todos
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missing import. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M dart/pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/members.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/resolution.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
5 years, 11 months ago (2015-01-09 11:44:19 UTC) #2
ahe
Sarah, Could you take a look in Johnni's absence?
5 years, 11 months ago (2015-01-12 08:55:00 UTC) #4
zarah
LGTM
5 years, 11 months ago (2015-01-12 09:15:44 UTC) #5
ahe
5 years, 11 months ago (2015-01-12 10:14:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698