Issue 837503002: Replace the use of local variables for irregexp registers by a typed array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 837503002: Replace the use of local variables for irregexp registers by a typed array. (Closed)

Created:
5 years, 11 months ago by zerny-google

Modified:
5 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Replace the use of local variables for irregexp registers by a typed array. The use of locals put considerable pressure on register allocation and caused lots of register shuffling. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42596

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -99 lines)			Patch
M	runtime/vm/regexp.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/regexp_assembler.h	View	4 chunks	+21 lines, -4 lines	0 comments	Download
M	runtime/vm/regexp_assembler.cc	View	25 chunks	+130 lines, -95 lines	0 comments	Download

Total messages: 3 (0 generated)

zerny-google

5 years, 11 months ago (2015-01-05 15:15:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42596 (presubmit successful).