Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 83743003: Add notion of current target isolate to ddbg.dart (Closed)

Created:
7 years, 1 month ago by hausner
Modified:
7 years, 1 month ago
Reviewers:
turnidge
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add notion of current target isolate to ddbg.dart Command li lists isolates in a vm and marks the current target isolate with an asterisk. Command sci sets the current target isolate to a particular isolate id. li List of isolates: 7115 paused at file: typed_message_test.dart lib: 12 token: 59 * 7112 running sci 7115 Setting current target isolate to 7115 li List of isolates: * 7115 paused at file: typed_message_test.dart lib: 12 token: 59 7112 running R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=30595

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -52 lines) Patch
M tools/ddbg.dart View 1 2 21 chunks +155 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 1 month ago (2013-11-22 18:09:53 UTC) #1
turnidge
LGTM with comments. https://codereview.chromium.org/83743003/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): https://codereview.chromium.org/83743003/diff/1/tools/ddbg.dart#newcode130 tools/ddbg.dart:130: currentIsolate.pausedLocation = null; I know that ...
7 years, 1 month ago (2013-11-22 19:24:00 UTC) #2
hausner
https://codereview.chromium.org/83743003/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): https://codereview.chromium.org/83743003/diff/1/tools/ddbg.dart#newcode130 tools/ddbg.dart:130: currentIsolate.pausedLocation = null; On 2013/11/22 19:24:00, turnidge wrote: > ...
7 years, 1 month ago (2013-11-22 22:54:42 UTC) #3
hausner
7 years, 1 month ago (2013-11-22 22:55:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r30595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698