dart2js: First part of native support in the new emitter.

dart2js: First part of native support in the new emitter.

R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42657

[floitsch, 2015-01-05 16:10:20]

floitsch@google.com changed reviewers:
+ sra@google.com, zarah@google.com

[floitsch, 2015-01-05 16:10:20]

Depends on https://chromiumcodereview.appspot.com/830923003/

[sra1, 2015-01-05 20:14:23]

lgtm

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/native_generator.dart (right):

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/native_generator.dart:9: static bool
needsBoilerplate(JavaScriptBackend backend) {
Like previous CL, I think this needs a better name.

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:99: boilerplate,
Use the uncached version unless you are sure that 'boilerplate' contains only
one of a finite number of strings.

[floitsch, 2015-01-06 12:54:58]

PTAL.

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/native_generator.dart (right):

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/native_generator.dart:9: static bool
needsBoilerplate(JavaScriptBackend backend) {
On 2015/01/05 20:14:23, sra1 wrote:
> Like previous CL, I think this needs a better name.

Done.

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:99: boilerplate,
On 2015/01/05 20:14:23, sra1 wrote:
> Use the uncached version unless you are sure that 'boilerplate' contains only
> one of a finite number of strings.

Boilerplate is a big string at the bottom of the file.
Am I missing something?

[sra1, 2015-01-07 04:43:28]

Still lgtm

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:99: boilerplate,
On 2015/01/06 12:54:57, floitsch wrote:
> On 2015/01/05 20:14:23, sra1 wrote:
> > Use the uncached version unless you are sure that 'boilerplate' contains
only
> > one of a finite number of strings.
> 
> Boilerplate is a big string at the bottom of the file.
> Am I missing something?

My bad.  I thought it was computed.
If it is a constant, give it a constant-like name.

[floitsch, 2015-01-07 13:11:46]

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/836753002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:99: boilerplate,
On 2015/01/07 04:43:28, sra1 wrote:
> On 2015/01/06 12:54:57, floitsch wrote:
> > On 2015/01/05 20:14:23, sra1 wrote:
> > > Use the uncached version unless you are sure that 'boilerplate' contains
> only
> > > one of a finite number of strings.
> > 
> > Boilerplate is a big string at the bottom of the file.
> > Am I missing something?
> 
> My bad.  I thought it was computed.
> If it is a constant, give it a constant-like name.

what's a constant-like name?
I wanted to use capitals but the editor is even warning me now...

[floitsch, 2015-01-07 13:12:01]

Committed patchset #4 (id:60001) manually as 42657 (presubmit successful).