Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 836703003: Define a lower threshold for optimizing irregexp generated functions. (Closed)

Created:
5 years, 11 months ago by zerny-google
Modified:
5 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Define a lower threshold for optimizing irregexp generated functions. The threshold is given by the flag --regexp_optimization_count_threshold and has a default value of 1000. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zerny-google
5 years, 11 months ago (2015-01-06 07:14:42 UTC) #1
Florian Schneider
lgtm
5 years, 11 months ago (2015-01-06 12:41:06 UTC) #2
zerny-google
5 years, 11 months ago (2015-01-06 13:56:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698