Issue 834383005: Don't perform incremental resolution if curly brackets are not balanced.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 834383005: Don't perform incremental resolution if curly brackets are not balanced. (Closed)

Created:
5 years, 11 months ago by scheglov

Modified:
5 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Don't perform incremental resolution if curly brackets are not balanced. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43022

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -4 lines)			Patch
M	pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	4 chunks	+37 lines, -1 line	2 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	3 chunks	+56 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/834383005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/834383005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1271 pkg/analyzer/lib/src/generated/incremental_resolver.dart:1271: // prepare ne unit 'ne' --> 'new' https://codereview.chromium.org/834383005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1502 ...

5 years, 11 months ago (2015-01-20 19:08:28 UTC) #2

scheglov

5 years, 11 months ago (2015-01-20 19:28:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43022 (presubmit successful).

Expand Messages | Collapse Messages