Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 834323002: Add modPow(int exponent, int modulus) method to int abstract class. (Closed)

Created:
5 years, 11 months ago by regis
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add modPow(int exponent, int modulus) method to int abstract class. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=42823

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M runtime/lib/bigint.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/integers.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/core/int.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
regis
Feel free to move the declaration around in the file and reword the comment. The ...
5 years, 11 months ago (2015-01-06 18:14:58 UTC) #2
floitsch
5 years, 11 months ago (2015-01-06 18:31:12 UTC) #4
regis
Still waiting on your review. Thanks, Regis
5 years, 11 months ago (2015-01-12 20:58:09 UTC) #5
Lasse Reichstein Nielsen
LGTM.
5 years, 11 months ago (2015-01-13 06:48:27 UTC) #6
regis
Thanks
5 years, 11 months ago (2015-01-13 17:13:14 UTC) #7
regis
5 years, 11 months ago (2015-01-13 17:14:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r42823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698