Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 834313003: Fix bug with percent formats with no integer part (Closed)

Created:
5 years, 11 months ago by Alan Knight
Modified:
5 years, 11 months ago
Reviewers:
tjblasi
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/intl.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M CHANGELOG.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
M lib/src/intl/number_format.dart View 1 2 chunks +6 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +1 line, -2 lines 0 comments Download
M test/number_format_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
5 years, 11 months ago (2015-01-06 19:09:50 UTC) #2
tjblasi
lgtm https://codereview.chromium.org/834313003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/834313003/diff/1/CHANGELOG.md#newcode1 CHANGELOG.md:1: ## 0.12.1 This should probably be 0.12.0+1. [https://www.dartlang.org/tools/pub/versioning.html#semantic-versions] ...
5 years, 11 months ago (2015-01-06 19:18:24 UTC) #3
Alan Knight
https://codereview.chromium.org/834313003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/834313003/diff/1/CHANGELOG.md#newcode1 CHANGELOG.md:1: ## 0.12.1 On 2015/01/06 19:18:23, tjblasi wrote: > This ...
5 years, 11 months ago (2015-01-06 19:22:17 UTC) #4
Alan Knight
5 years, 11 months ago (2015-01-06 19:25:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2d1af4a91d6fb6fcd89fdc3efb99490d79d3bb96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698